lkml.org 
[lkml]   [2015]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/9] arm: twr-k70f120m: timer driver for Kinetis SoC
On Wed, 1 Jul 2015, Paul Osmialowski wrote:

> Hi Thomas,
>
> On Wed, 1 Jul 2015, Thomas Gleixner wrote:
>
> > > + clockevents_register_device(
> > > + &kinetis_clockevent_tmrs[chan].evtdev);
> > > +
> > > + kinetis_pit_init(&kinetis_clockevent_tmrs[chan],
> > > + (rate / HZ) - 1);
> > > + kinetis_pit_enable(&kinetis_clockevent_tmrs[chan], 1);
> >
> > No point doing this. The core code has invoked the set_periodic call
> > back via clockevents_register_device() already.
> >
>
> As I removed this kinetis_pit_enable() line, the timer did not start,
> therefore the system became unusable. What could be possible reason for that?

Well, you need to move both, the init and the enable into
set_periodic().

Thanks,

tglx



\
 
 \ /
  Last update: 2015-07-01 15:41    [W:1.311 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site