Messages in this thread | | | Date | Tue, 09 Jun 2015 19:22:08 +0100 | From | Srinivas Kandagatla <> | Subject | Re: [PATCH v5 2/2] ASoC: qcom: add apq8016 sound card support |
| |
On 09/06/15 19:04, Mark Brown wrote: > On Tue, Jun 09, 2015 at 06:51:59PM +0100, Srinivas Kandagatla wrote: >> On 09/06/15 18:07, Mark Brown wrote: > >>> Why not just do these one time at probe, we don't undo them when we shut >>> the DAI down? > >> If I do that Am afraid that the driver would loose the flexibility of >> selecting different MI2S from DT level. Hardcoding which MI2S can got to >> external or internal codec is something that I wanted to avoid from the >> start. > > I don't understand why we'd loose anything - we get init() callbacks on > the DAIs when they're instantiated? > Yes, got it. At dai_link init() level we can do it without losing any flexibility.
My bad, I thought you initially suggested me to add this to platform probe() level.
>> I will add the shutdown code to reset the configuration. > > OK. >
| |