Messages in this thread Patch in this message | | | Date | Tue, 9 Jun 2015 16:55:53 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v4] Staging: rtl8192e: Casting correct Endianness |
| |
On Tue, Jun 09, 2015 at 12:22:27PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote: > From: Gnanachandran Dhanapal <gdhanapa@visteon.com> > > Casting correct Endianness for __le16 variable used in assignment and > condition check > > Signed-off-by: Gnanachandran Dhanapal <gdhanapa@visteon.com> > --- > v4: Greg review comments addressed
Which ones?
> @@ -2244,8 +2244,9 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb, > struct rtllib_assoc_response_frame *assoc_resp; > struct rtllib_hdr_3addr *header = (struct rtllib_hdr_3addr *) skb->data; > > + u16 frame_ctl = le16_to_cpu(header->frame_ctl); > netdev_dbg(ieee->dev, "received [RE]ASSOCIATION RESPONSE (%d)\n", > - WLAN_FC_GET_STYPE(header->frame_ctl)); > + WLAN_FC_GET_STYPE(frame_ctl)); >
Blank line in the wrong spot.
regards, dan carpenter
| |