lkml.org 
[lkml]   [2015]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tpmdd-devel] [PATCH v2] tpm: introduce struct tpm_buf
On Tue, Jun 09, 2015 at 12:32:57PM +0200, Peter Huewe wrote:
>
>
> Hi
>
> >> > +static inline void tpm_buf_store(struct tpm_buf *buf,
> >> > + unsigned int pos,
> >> > + const unsigned char *data,
> >> > + unsigned int len)
> >> > +{
> >> > + BUG_ON((pos + len) > TPM_BUF_SIZE);
> >> > +
> >> > + memcpy(&buf->data[pos], data, len);
> >> > +}
> >>
> >> Don't you have to update the ->length here?
> >
> >No. Store is for placing value in position, not appending to the end.
> >
> Then either add a length check (whether ->length is big enough) and/or
> call the function "update"

There is a length check in the beginning (first line of the function
body).

> Peter

/Jarkko


\
 
 \ /
  Last update: 2015-06-09 14:01    [W:0.056 / U:23.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site