lkml.org 
[lkml]   [2015]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v14 1/4] cgroup: fix uninitialised iterator in for_each_subsys_which
    Date
    Fix the fact that @ssid is uninitialised in the case where
    CGROUP_SUBSYS_COUNT = 0 by setting ssid to 0.

    Fixes: cb4a31675270 ("cgroup: use bitmask to filter for_each_subsys")
    Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
    ---
    kernel/cgroup.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/cgroup.c b/kernel/cgroup.c
    index 6d6d3c7..12b580f 100644
    --- a/kernel/cgroup.c
    +++ b/kernel/cgroup.c
    @@ -424,7 +424,7 @@ static int notify_on_release(const struct cgroup *cgrp)
    */
    #define for_each_subsys_which(ss, ssid, ss_maskp) \
    if (!CGROUP_SUBSYS_COUNT) /* to avoid spurious gcc warning */ \
    - ; \
    + (ssid) = 0; \
    else \
    for_each_set_bit(ssid, ss_maskp, CGROUP_SUBSYS_COUNT) \
    if (((ss) = cgroup_subsys[ssid]) && false) \
    --
    2.4.2


    \
     
     \ /
      Last update: 2015-06-09 13:41    [W:2.146 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site