Messages in this thread | | | Date | Tue, 9 Jun 2015 08:56:31 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 8/8] mfd: si476x-i2c: Pass the IRQF_ONESHOT flag |
| |
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject > bogus threaded irq requests") threaded IRQs without a primary handler > need to be requested with IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > The semantic patch that makes this change is available > in scripts/coccinelle/misc/irqf_oneshot.cocci. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/mfd/si476x-i2c.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c > index 7f87c62..e3deb46 100644 > --- a/drivers/mfd/si476x-i2c.c > +++ b/drivers/mfd/si476x-i2c.c > @@ -777,7 +777,8 @@ static int si476x_core_probe(struct i2c_client *client, > rval = devm_request_threaded_irq(&client->dev, > client->irq, NULL, > si476x_core_interrupt, > - IRQF_TRIGGER_FALLING, > + IRQF_TRIGGER_FALLING | > + IRQF_ONESHOT, > client->name, core); > if (rval < 0) { > dev_err(&client->dev, "Could not request IRQ %d\n",
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |