lkml.org 
[lkml]   [2015]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 1/5] fs: kiocb: introduce IOCB_DONT_DIRTY_PAGE flag for direct IO
From
On Fri, Jun 5, 2015 at 11:03 PM, Christoph Hellwig <hch@infradead.org> wrote:
> As mentioned last time a big fat NAK for this one. We generally
> do not dirty kernel pages anywhere, so a flag that must alway be set
> for default behavior just to prepare for a highy hypothetical user that
> in the future might want to abuse the interface is a no-go.
>
> Just make the dirtying behavior dependent on the iov_iter type:
> dirty for ITER_IOVEC and do nothing for ITER_KVEC and ITER_BVEC.

Both ITER_KVEC and ITER_BVEC doesn't mean the pages are kernel
page, for example of loop and swap. That is why this patch is more flexiable,
and won't cause regression since the users may have different dirtying
rules as you mentioned last time.

http://marc.info/?t=143093223200001&r=1&w=2

Thanks,
Ming


\
 
 \ /
  Last update: 2015-06-06 03:21    [W:0.058 / U:1.816 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site