lkml.org 
[lkml]   [2015]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v14 15/19] perf, tools: Support long descriptions with perf list
On Fri, Jun 05, 2015 at 12:21:38PM +0200, Jiri Olsa wrote:
> On Thu, Jun 04, 2015 at 11:27:23PM -0700, Sukadev Bhattiprolu wrote:
>
> SNIP
>
> > ---
> > tools/perf/builtin-list.c | 11 ++++++++---
> > 1 file changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> > index 3f058f7..d0f7a18 100644
> > --- a/tools/perf/builtin-list.c
> > +++ b/tools/perf/builtin-list.c
> > @@ -22,10 +22,13 @@ int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
> > {
> > int i;
> > bool raw_dump = false;
> > + bool long_desc_flag = false;
> > struct option list_options[] = {
> > OPT_BOOLEAN(0, "raw-dump", &raw_dump, "Dump raw events"),
> > OPT_BOOLEAN('d', "desc", &desc_flag,
> > "Print extra event descriptions. --no-desc to not print."),
> > + OPT_BOOLEAN('d', "long-desc", &long_desc_flag,
> > + "Print longer event descriptions."),
>
> hum, it should be 'v' , right?

Yes that's right.

Also BTW need to add the new option to the usage line a few lines below.

-Andi

--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2015-06-05 18:41    [W:0.066 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site