Messages in this thread | | | Date | Fri, 5 Jun 2015 08:03:48 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 1/5] fs: kiocb: introduce IOCB_DONT_DIRTY_PAGE flag for direct IO |
| |
As mentioned last time a big fat NAK for this one. We generally do not dirty kernel pages anywhere, so a flag that must alway be set for default behavior just to prepare for a highy hypothetical user that in the future might want to abuse the interface is a no-go.
Just make the dirtying behavior dependent on the iov_iter type: dirty for ITER_IOVEC and do nothing for ITER_KVEC and ITER_BVEC.
| |