lkml.org 
[lkml]   [2015]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tile: add init.h to usb.c to avoid compile failure
On 06/05/2015 10:36 AM, Paul Gortmaker wrote:
> Pending header cleanups will reveal this file is using the
> init.h content implicitly with the following fail:
>
> arch/tile/kernel/usb.c:69:1: warning: data definition has no type or storage class [enabled by default]
> arch/tile/kernel/usb.c:69:1: error: type defaults to 'int' in declaration of 'arch_initcall'
> arch/tile/kernel/usb.c:69:1: warning: parameter names (without types) in function declaration [enabled by default]
> arch/tile/kernel/usb.c:62:19: warning: 'tilegx_usb_init' defined but not used
>
> Explicitly add init.h to get arch_initcall and avoid this.
>
> Reported-by: kbuild test robot<fengguang.wu@intel.com>
> Cc: Chris Metcalf<cmetcalf@ezchip.com>
> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
> ---
>
> [adding this to the header move series of commits; see
> https://lkml.kernel.org/r/1433276168-21550-1-git-send-email-paul.gortmaker@windriver.com
> for original series posting. ]
>
> arch/tile/kernel/usb.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Chris Metcalf <cmetcalf@ezchip.com>

or I'm happy to take it into the tile tree if you'd rather I did.

--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com



\
 
 \ /
  Last update: 2015-06-05 17:01    [W:0.042 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site