lkml.org 
[lkml]   [2015]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 054/110] kernel: use the gnu89 standard explicitly
    Date
    3.16.7-ckt13 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Kirill A. Shutemov" <kirill@shutemov.name>

    commit 51b97e354ba9fce1890cf38ecc754aa49677fc89 upstream.

    Sasha Levin reports:
    "gcc5 changes the default standard to c11, which makes kernel build
    unhappy

    Explicitly define the kernel standard to be gnu89 which should keep
    everything working exactly like it was before gcc5"

    There are multiple small issues with the new default, but the biggest
    issue seems to be that the old - and very useful - GNU extension to
    allow a cast in front of an initializer has gone away.

    Patch updated by Kirill:
    "I'm pretty sure all gcc versions you can build kernel with supports
    -std=gnu89. cc-option is redunrant.

    We also need to adjust HOSTCFLAGS otherwise allmodconfig fails for me"

    Note by Andrew Pinski:
    "Yes it was reported and both problems relating to this extension has
    been added to gnu99 and gnu11. Though there are other issues with the
    kernel dealing with extern inline have different semantics between
    gnu89 and gnu99/11"

    End result: we may be able to move up to a newer stdc model eventually,
    but right now the newer models have some annoying deficiencies, so the
    traditional "gnu89" model ends up being the preferred one.

    Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
    Singed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Philip Müller <philm@manjaro.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    Makefile | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/Makefile b/Makefile
    index c2c3ab88cea7..8b63a6640123 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -303,7 +303,7 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \

    HOSTCC = gcc
    HOSTCXX = g++
    -HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer
    +HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -std=gnu89
    HOSTCXXFLAGS = -O2

    ifeq ($(shell $(HOSTCC) -v 2>&1 | grep -c "clang version"), 1)
    @@ -406,7 +406,8 @@ KBUILD_CPPFLAGS := -D__KERNEL__
    KBUILD_CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
    -fno-strict-aliasing -fno-common \
    -Werror-implicit-function-declaration \
    - -Wno-format-security
    + -Wno-format-security \
    + -std=gnu89

    KBUILD_AFLAGS_KERNEL :=
    KBUILD_CFLAGS_KERNEL :=

    \
     
     \ /
      Last update: 2015-06-05 16:21    [W:4.033 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site