lkml.org 
[lkml]   [2015]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/cpu: Fix SMAP check in PVOPS environments

* Rusty Russell <rusty@rustcorp.com.au> wrote:

> As the comment in arch/x86/include/asm/paravirt_types.h says:
>
> * Get/set interrupt state. save_fl and restore_fl are only
> * expected to use X86_EFLAGS_IF; all other bits
> * returned from save_fl are undefined, and may be ignored by
> * restore_fl.

There should be no 'may' about this: under CONFIG_PARAVIRT_DEBUG=y the reminder of
the flags should be cleared (or all bits should be set: that will instantly crash
if restored verbatim), so that we trip up generic code that relies on non-IF
restoration?

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-06-05 09:41    [W:0.053 / U:1.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site