lkml.org 
[lkml]   [2015]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Getting rid of i7300_idle's idle notifier?

* Andy Lutomirski <luto@amacapital.net> wrote:

> On Thu, Jun 4, 2015 at 4:32 PM, Andy Lutomirski <luto@kernel.org> wrote:
>
> > AFAICT the sole purpose for the hideous x86_64 idle_notifier mess is to
> > support i7300_idle. IMO this junk does not belong in IRQ handling, etc. Can
> > we redo this to work in some kind of generic way?
> >
> > I have no idea why it makes sense to twiddle I/O AT registers in the beginning
> > of whatever IRQ wakes up the CPU.
> >
> > Note that, if absolutely necessary, the ECX bit 0 MWAIT extension can be used
> > to reliably execute code before handling interrupts that wake us from idle.
> > That is, there could be a real cpuidle driver for that chip that does:
> >
> > cli;
> > poke ioat;
> > mwait(ecx = 1);
> > poke ioat;
> > sti;
> >
> > Or we could delete the driver entirely.
>
> It's even easier than that. Just shove the hooks into acpi_idle_do_entry or
> similar and remove them from every other exit_idle call site in the kernel.

Yes!

Interested in doing a patch?

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-06-05 09:21    [W:0.070 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site