lkml.org 
[lkml]   [2015]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/asm/msr: Retract msr-index.h

* H. Peter Anvin <hpa@zytor.com> wrote:

> On 06/03/2015 11:21 AM, Borislav Petkov wrote:
> > On Wed, Jun 03, 2015 at 02:41:48PM +0200, Borislav Petkov wrote:
> >> This header containing all MSRs and respective bit definitions got
> >> exported to userspace in conjunction with the big uapi shuffle.
> >>
> >> But, it doesn't have anything to do in the uapi headers because
> >> userspace can do its own MSR defines and exporting them from the
> >> kernel blocks us from doing cleanups/renames in that header. Which is
> >> ridiculous - it is not kernel's job to export such a header and keep
> >> MSRs list and their names stable.
> >
> > Here's v2. Needed to *not* include it into uapi/asm/msr.h either.
>
> I really like the patch, but the description is awful.
>
> How about: "x86/uapi: <asm/msr.h> is not a UAPI"

So a small nit: a simple statement of fact is not really a proper commit title.
A commit title should express what the patch _does_.

Missing leading verbs are really passive-aggressive on the reader of a flow of
commit titles - such as when reading a short log or a one-line git log.

Something like:

x86/uapi: Remove <asm/msr.h> from the list of exported UAPI headers

or so would work fine with me.

Thanks!

Ingo


\
 
 \ /
  Last update: 2015-06-04 08:21    [W:0.079 / U:1.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site