lkml.org 
[lkml]   [2015]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses
On 03/06/15 18:06, Joe Perches wrote:
> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
>> rx->status is an int16_t, print it using %d rather than %u in order to
>> have a meaningful value when the field is negative.
> []
>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> []
>> @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue,
>> if (unlikely(rx->status < 0 ||
>> rx->offset + rx->status > PAGE_SIZE)) {
>> if (net_ratelimit())
>> - dev_warn(dev, "rx->offset: %x, size: %u\n",
>> + dev_warn(dev, "rx->offset: %x, size: %d\n",
>
> If you're going to do this, perhaps it'd be sensible to
> also change the %x to %#x or 0x%x so that people don't
> mistake offset without an [a-f] for decimal.

Good idea. I will resend a version of this series.

David, can I keep you Reviewed-by for this change?

--
Julien Grall


\
 
 \ /
  Last update: 2015-06-04 15:01    [W:0.650 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site