lkml.org 
[lkml]   [2015]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] macintosh: Delete an unnecessary check before the function call "of_node_put"
    Am 04.02.2015 um 21:36 schrieb SF Markus Elfring:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Wed, 4 Feb 2015 21:32:27 +0100
    >
    > The of_node_put() function tests whether its argument is NULL and then
    > returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/macintosh/smu.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c
    > index 10ae69b..d531f80 100644
    > --- a/drivers/macintosh/smu.c
    > +++ b/drivers/macintosh/smu.c
    > @@ -557,8 +557,7 @@ int __init smu_init (void)
    > return 0;
    >
    > fail_msg_node:
    > - if (smu->msg_node)
    > - of_node_put(smu->msg_node);
    > + of_node_put(smu->msg_node);
    > fail_db_node:
    > of_node_put(smu->db_node);
    > fail_bootmem:
    >

    Would you like to integrate this update suggestion
    into another source code repository?

    Regards,
    Markus


    \
     
     \ /
      Last update: 2015-06-30 10:21    [W:4.018 / U:1.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site