Messages in this thread | | | Date | Wed, 03 Jun 2015 10:46:17 +0300 | From | Vladimir Barinov <> | Subject | Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC |
| |
Hi Paul,
On 03.06.2015 10:05, Paul Bolle wrote: > Just a nit, that I spotted while scanning for other issues. > > On Mon, 2015-06-01 at 15:20 +0300, Vladimir Barinov wrote: >> --- /dev/null >> +++ b/drivers/iio/adc/hi-843x.c >> +ssize_t hi843x_debounce_soft_show(struct device *dev, >> + struct device_attribute *attr, char *buf) >> +{ >> + [...] >> +} >> + >> +[...] >> + >> +ssize_t hi843x_threshold_socval_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, size_t len) >> +{ >> + [...] >> +} > It seems all these *_show and *_store functions should be made static, > right? Right. Thank you for pointing to this.
Regards, Vladimir
| |