Messages in this thread | | | Subject | Re: [PATCH 1/3] iio: adc: hi-843x: Holt HI-8435/8436/8437 descrete ADC | From | Paul Bolle <> | Date | Wed, 03 Jun 2015 09:05:57 +0200 |
| |
Just a nit, that I spotted while scanning for other issues.
On Mon, 2015-06-01 at 15:20 +0300, Vladimir Barinov wrote: > --- /dev/null > +++ b/drivers/iio/adc/hi-843x.c
> +ssize_t hi843x_debounce_soft_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + [...] > +} >+ >+[...] >+ > +ssize_t hi843x_threshold_socval_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t len) > +{ > + [...] > +}
It seems all these *_show and *_store functions should be made static, right?
> +static IIO_DEVICE_ATTR(debounce_soft, S_IRUGO | S_IWUSR, > + hi843x_debounce_soft_show, hi843x_debounce_soft_store, 0); > +static IIO_DEVICE_ATTR(debounce_soft_delay, S_IRUGO | S_IWUSR, > + hi843x_debounce_soft_delay_show, hi843x_debounce_soft_delay_store, 0); > +static IIO_DEVICE_ATTR(sensing_mode, S_IRUGO | S_IWUSR, > + hi843x_sensing_mode_show, hi843x_sensing_mode_store, 0); > +static IIO_DEVICE_ATTR(test_enable, S_IRUGO | S_IWUSR, > + hi843x_test_enable_show, hi843x_test_enable_store, 0); > +static IIO_DEVICE_ATTR(test_mode, S_IRUGO | S_IWUSR, > + hi843x_test_mode_show, hi843x_test_mode_store, 0); > +static IIO_DEVICE_ATTR(threshold_gohys, S_IRUGO | S_IWUSR, > + hi843x_threshold_gohys_show, hi843x_threshold_gohys_store, 0); > +static IIO_DEVICE_ATTR(threshold_gocval, S_IRUGO | S_IWUSR, > + hi843x_threshold_gocval_show, hi843x_threshold_gocval_store, 0); > +static IIO_DEVICE_ATTR(threshold_sohys, S_IRUGO | S_IWUSR, > + hi843x_threshold_sohys_show, hi843x_threshold_sohys_store, 0); > +static IIO_DEVICE_ATTR(threshold_socval, S_IRUGO | S_IWUSR, > + hi843x_threshold_socval_show, hi843x_threshold_socval_store, 0);
Thanks,
Paul Bolle
| |