lkml.org 
[lkml]   [2015]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.0 023/148] Revert "libceph: clear r_req_lru_item in __unregister_linger_request()"
    Date
    4.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ilya Dryomov <idryomov@gmail.com>

    commit 521a04d06a729e5971cdee7f84080387ed320527 upstream.

    This reverts commit ba9d114ec5578e6e99a4dfa37ff8ae688040fd64.

    .. which introduced a regression that prevented all lingering requests
    requeued in kick_requests() from ever being sent to the OSDs, resulting
    in a lot of missed notifies. In retrospect it's pretty obvious that
    r_req_lru_item item in the case of lingering requests can be used not
    only for notarget, but also for unsent linkage due to how tightly
    actual map and enqueue operations are coupled in __map_request().

    The assertion that was being silenced is taken care of in the previous
    ("libceph: request a new osdmap if lingering request maps to no osd")
    commit: by always kicking homeless lingering requests we ensure that
    none of them ends up on the notarget list outside of the critical
    section guarded by request_mutex.

    Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
    Reviewed-by: Sage Weil <sage@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/ceph/osd_client.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/net/ceph/osd_client.c
    +++ b/net/ceph/osd_client.c
    @@ -1306,8 +1306,6 @@ static void __unregister_linger_request(
    if (list_empty(&req->r_osd_item))
    req->r_osd = NULL;
    }
    -
    - list_del_init(&req->r_req_lru_item); /* can be on notarget */
    ceph_osdc_put_request(req);
    }




    \
     
     \ /
      Last update: 2015-06-03 15:21    [W:4.069 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site