lkml.org 
[lkml]   [2015]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.0 042/148] hwmon: (nct6683) Add missing sysfs attribute initialization
    Date
    4.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Guenter Roeck <linux@roeck-us.net>

    commit c7bd6dc320b85445b6b36a0aff41f929210027c7 upstream.

    The following error message is seen when loading the nct6683 driver
    with DEBUG_LOCK_ALLOC enabled.

    BUG: key ffff88040b2f0030 not in .data!
    ------------[ cut here ]------------
    WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
    lockdep_init_map+0x469/0x630()
    DEBUG_LOCKS_WARN_ON(1)

    Caused by a missing call to sysfs_attr_init() when initializing
    sysfs attributes.

    Reported-by: Alexey Orishko <alexey.orishko@gmail.com>
    Reviewed-by: Jean Delvare <jdelvare@suse.de>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hwmon/nct6683.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/hwmon/nct6683.c
    +++ b/drivers/hwmon/nct6683.c
    @@ -439,6 +439,7 @@ nct6683_create_attr_group(struct device
    (*t)->dev_attr.attr.name, tg->base + i);
    if ((*t)->s2) {
    a2 = &su->u.a2;
    + sysfs_attr_init(&a2->dev_attr.attr);
    a2->dev_attr.attr.name = su->name;
    a2->nr = (*t)->u.s.nr + i;
    a2->index = (*t)->u.s.index;
    @@ -449,6 +450,7 @@ nct6683_create_attr_group(struct device
    *attrs = &a2->dev_attr.attr;
    } else {
    a = &su->u.a1;
    + sysfs_attr_init(&a->dev_attr.attr);
    a->dev_attr.attr.name = su->name;
    a->index = (*t)->u.index + i;
    a->dev_attr.attr.mode =



    \
     
     \ /
      Last update: 2015-06-03 14:41    [W:4.128 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site