Messages in this thread | | | Subject | Re: [PATCH v9 1/3] x86/setup: introduce setup_bultin_cmdline | From | Andy Shevchenko <> | Date | Wed, 03 Jun 2015 12:30:12 +0300 |
| |
On Wed, 2015-06-03 at 13:55 +0600, Alexander Kuleshov wrote: > This patch introduces the setup_builtin_cmdline function which appends or > overrides boot_command_line with the builtin_cmdline if CONFIG_CMDLINE_BOOL > is set.
> Previously this functional was in the setup_arch, but we need to move > it for getting actual command line as early as possible in the > arch/x86/kernel/head{32,64}.c for the earlyprintk setup.
[]
> --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -733,7 +733,7 @@ static void __init trim_snb_memory(void) > * already been reserved. > */ > memblock_reserve(0, 1<<20); > - > + > for (i = 0; i < ARRAY_SIZE(bad_pages); i++) { > if (memblock_reserve(bad_pages[i], PAGE_SIZE)) > printk(KERN_WARNING "failed to reserve 0x%08lx\n", > @@ -825,7 +825,7 @@ static void __init trim_low_memory_range(void) > { > memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE)); > } > - > + > /* > * Dump out kernel offset information on panic. > */
You again mixed things in one patch. Style thing if you wish shall go separately.
-- Andy Shevchenko <andriy.shevchenko@intel.com> Intel Finland Oy
| |