lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Subject: [PATCH 1/2] staging : Comedi : comedi_fops : Fixed the return error, code
On 29/06/15 10:15, Ian Abbott wrote:
> On 27/06/15 06:36, Santhosh Pai wrote:
>>
>> From 9ea09e194d6ccdd0b229b408df1c86b43b1fdd7d Mon Sep 17 00:00:00 2001
>> From: santhosh pai <santhosh.pai88@yahoo.com>
>> Date: Mon, 22 Jun 2015 23:26:33 +0530
>> Subject: [PATCH 2/2] staging : Comedi : comedi_fops : Fixed the return
>> error
>> code
>>
>> try_module_get fails when the reference count of the module is not
>> allowed to be incremented ,and hence -ENXIO is returned indicating
>> no device or address.
>>
>> Signed-off-by: santhosh pai <santhosh.pai88@yahoo.com>
>> ---
>> drivers/staging/comedi/comedi_fops.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/comedi/comedi_fops.c
>> b/drivers/staging/comedi/comedi_fops.c
>> index d6a37e9..1ab443c 100644
>> --- a/drivers/staging/comedi/comedi_fops.c
>> +++ b/drivers/staging/comedi/comedi_fops.c
>> @@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode,
>> struct file *file)
>> }
>> if (dev->attached && dev->use_count == 0) {
>> if (!try_module_get(dev->driver->module)) {
>> - rc = -EPERM;
>> + rc = -ENXIO;
>> goto out;
>> }
>> if (dev->open) {
>>
>
> The patch itself is okay, but all the stuff around the patch is a bit
> weird, such as:
>
> 1. all those email headers in the commit message
> 2. useless indentation in the commit message
> 3. subject line in commit message says "PATCH 2/2", but email subject
> line says "PATCH 1/2"
> 4. stray comma in email subject line
> 5. spaces before colon in subject lines

Actually, the patch doesn't apply, because it's on top of your other
patch that changed -ENOSYS to -EPERM.

>
> This is taking too long, so I'll post a cleaned-up version.
>

I'll combine your two changes to the error return value into a single patch.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-06-29 11:41    [W:0.075 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site