Messages in this thread | | | Date | Mon, 29 Jun 2015 11:28:05 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 3/3] printk: implement support for extended console drivers |
| |
Hello,
On Mon, Jun 29, 2015 at 11:20:41AM +0200, Geert Uytterhoeven wrote: > On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo <tj@kernel.org> wrote: > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > > @@ -2196,6 +2227,7 @@ out: > > */ > > void console_unlock(void) > > { > > + static char ext_text[CONSOLE_EXT_LOG_MAX]; > > Can you please > a) make this feature optional,
netconsole itself is optional & modular. I'm not sure making further splits is called for, especially given the use cases.
> b) (de)allocate this buffer dynamically when the first/last console with > CON_EXTENDED set is (un)registered?
But yeah, making the buffer allocated on demand should be simple enough. Will get to it.
Thanks.
-- tejun
| |