lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]drivers:staging:visorbus:Fix checkpatch warnings
On Sun, Jun 28, 2015 at 10:24:49PM +0530, Ravi Teja wrote:
>
> This patch fixes checkpatch warnings
>
> Signed-off-by: Ravi Teja Darbha <ravi2j@gmail.com>

David,

Is this code removed after you ripped out the parahotplug stuff?
IOW, the next round of updates from Ben might obsolete this patch.

Cheers,
Don

> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index bb8087e..62f7f68 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -1410,8 +1410,8 @@ visorchipset_chipset_ready(void)
> static int
> visorchipset_chipset_selftest(void)
> {
> - char env_selftest[20];
> - char *envp[] = { env_selftest, NULL };
> + static char env_selftest[20];
> + static const char * const envp[] = { env_selftest, NULL };
>
> sprintf(env_selftest, "SPARSP_SELFTEST=%d", 1);
> kobject_uevent_env(&visorchipset_platform_device.dev.kobj, KOBJ_CHANGE,
> @@ -1559,9 +1559,9 @@ static void
> parahotplug_request_kickoff(struct parahotplug_request *req)
> {
> struct controlvm_message_packet *cmd = &req->msg.cmd;
> - char env_cmd[40], env_id[40], env_state[40], env_bus[40], env_dev[40],
> - env_func[40];
> - char *envp[] = {
> + static char env_cmd[40], env_id[40], env_state[40], env_bus[40],
> + env_dev[40], env_func[40];
> + static const char * const envp[] = {
> env_cmd, env_id, env_state, env_bus, env_dev, env_func, NULL
> };
>
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2015-06-29 16:01    [W:0.046 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site