lkml.org 
[lkml]   [2015]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] cxl/vphb.c: Use phb pointer after NULL check
From
Date
On Mon, 2015-06-29 at 16:05 +0530, Maninder Singh wrote:
> static Anlaysis detected below error:-
> (error) Possible null pointer dereference: phb
>
> So, Use phb after NULL check.
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>

Thanks, looks good.

Acked-By: Michael Neuling <mikey@neuling.org>

> ---
> drivers/misc/cxl/vphb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c
> index b1d1983a..2eba002 100644
> --- a/drivers/misc/cxl/vphb.c
> +++ b/drivers/misc/cxl/vphb.c
> @@ -112,9 +112,10 @@ static int cxl_pcie_config_info(struct pci_bus *bus, unsigned int devfn,
> unsigned long addr;
>
> phb = pci_bus_to_host(bus);
> - afu = (struct cxl_afu *)phb->private_data;
> if (phb == NULL)
> return PCIBIOS_DEVICE_NOT_FOUND;
> + afu = (struct cxl_afu *)phb->private_data;
> +
> if (cxl_pcie_cfg_record(bus->number, devfn) > afu->crs_num)
> return PCIBIOS_DEVICE_NOT_FOUND;
> if (offset >= (unsigned long)phb->cfg_data)



\
 
 \ /
  Last update: 2015-06-29 13:01    [W:0.060 / U:3.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site