lkml.org 
[lkml]   [2015]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] ipmi: Delete an unnecessary check before the function call "cleanup_one_si"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 27 Jun 2015 18:12:14 +0200

    The cleanup_one_si() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/char/ipmi/ipmi_si_intf.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
    index cb90f76..fbfed36 100644
    --- a/drivers/char/ipmi/ipmi_si_intf.c
    +++ b/drivers/char/ipmi/ipmi_si_intf.c
    @@ -2778,9 +2778,7 @@ static int ipmi_remove(struct platform_device *dev)
    {
    struct smi_info *info = dev_get_drvdata(&dev->dev);

    - if (info)
    - cleanup_one_si(info);
    -
    + cleanup_one_si(info);
    return 0;
    }

    --
    2.4.4


    \
     
     \ /
      Last update: 2015-06-27 18:21    [W:4.135 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site