Messages in this thread | | | Date | Fri, 26 Jun 2015 16:06:55 -0700 | From | Darren Hart <> | Subject | Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister() |
| |
On Thu, Nov 27, 2014 at 07:13:10PM +0100, Julia Lawall wrote: > > > On Mon, 24 Nov 2014, SF Markus Elfring wrote: > > > >> This issue was detected by using the Coccinelle software. > > > > > > What script was used ? > > > > A semantic patch approach which I published on the mailing lists in March > > is in action on my software development system for a while. > > > > > > > Is it in scripts/coccinelle ? > > > > Not yet. > > > > I hope that the involved update suggestions got sufficient positive feedback > > to integrate five scripts there. > > The current scripts are very complicated, involving the interaction > between multiple scripts and a database, and I think they are not very > suitable for make coccicheck. Also, the idea of removing the null checks > is not appropriate in all contexts. Perhaps it could be possible to add > a script to the Linux kernel that handles a number of common cases for > which removing the null test is widely considered to be desirable. > > julia >
Julia, do you have any particular objection to this specific patch? I didn't see a reason to prevent it going in.
-- Darren Hart Intel Open Source Technology Center
| |