lkml.org 
[lkml]   [2015]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] crypto-qat: Deletion of unnecessary checks before two function calls
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 26 Jun 2015 20:30:11 +0200

    The functions kfree() and release_firmware() test whether their argument
    is NULL and then return immediately.
    Thus the test around the calls is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/crypto/qat/qat_common/adf_accel_engine.c | 5 +----
    drivers/crypto/qat/qat_common/adf_transport.c | 2 +-
    2 files changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/crypto/qat/qat_common/adf_accel_engine.c b/drivers/crypto/qat/qat_common/adf_accel_engine.c
    index 7f8b66c..fdda8e7 100644
    --- a/drivers/crypto/qat/qat_common/adf_accel_engine.c
    +++ b/drivers/crypto/qat/qat_common/adf_accel_engine.c
    @@ -88,10 +88,7 @@ void adf_ae_fw_release(struct adf_accel_dev *accel_dev)

    qat_uclo_del_uof_obj(loader_data->fw_loader);
    qat_hal_deinit(loader_data->fw_loader);
    -
    - if (loader_data->uof_fw)
    - release_firmware(loader_data->uof_fw);
    -
    + release_firmware(loader_data->uof_fw);
    loader_data->uof_fw = NULL;
    loader_data->fw_loader = NULL;
    }
    diff --git a/drivers/crypto/qat/qat_common/adf_transport.c b/drivers/crypto/qat/qat_common/adf_transport.c
    index ccec3274..db2926b 100644
    --- a/drivers/crypto/qat/qat_common/adf_transport.c
    +++ b/drivers/crypto/qat/qat_common/adf_transport.c
    @@ -449,7 +449,7 @@ static int adf_init_bank(struct adf_accel_dev *accel_dev,
    err:
    for (i = 0; i < ADF_ETR_MAX_RINGS_PER_BANK; i++) {
    ring = &bank->rings[i];
    - if (hw_data->tx_rings_mask & (1 << i) && ring->inflights)
    + if (hw_data->tx_rings_mask & (1 << i))
    kfree(ring->inflights);
    }
    return -ENOMEM;
    --
    2.4.4


    \
     
     \ /
      Last update: 2015-06-26 21:01    [W:7.686 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site