lkml.org 
[lkml]   [2015]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] blkcg: move io_service_bytes and io_serviced stats into blkcg_gq
Hello, Vivek.

On Fri, Jun 26, 2015 at 12:01:42PM -0400, Vivek Goyal wrote:
> - Previously throttling policy was calculating number of IOs in terms of
> number of bios while CFQ was calculating it in terms of number of
> requests. I think this will be a behavior change now? IIUC, now even
> throttling policy will report number of requests and number of bios.

Yes, it'd be. I'll mention it in the description. The thing is this
has never been documented or explained properly. The only thing
userland saw would be the counts deviating over time. I don't think
putting them on the same measure is gonna break anything.

> - Looks like completion and stat is now lined to request. I am wondering
> what will happen to bio based targets. One can put a throttling policy
> on any of the stacked dm devices. I suspect we will be broken there?

Dang, I forgot about bio based drivers. I don't care whether it
counts bios or requests. The only thing I want is counting the same
thing once instead of separately in subtly different ways. I'll
converge them to bios.

> - Can you please also update the blkio-controller.txt. Specifically
> blkio.throttle.io_serviced.

Sure, will do.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2015-06-26 18:21    [W:0.068 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site