lkml.org 
[lkml]   [2015]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: fix set pageblock migratetype when boot
On Fri, Jun 26, 2015 at 06:09:05PM +0800, Xishi Qiu wrote:
> memmap_init_zone()
> ...
> if ((z->zone_start_pfn <= pfn)
> && (pfn < zone_end_pfn(z))
> && !(pfn & (pageblock_nr_pages - 1)))
> set_pageblock_migratetype(page, MIGRATE_MOVABLE);
> ...
>
> If the pfn does not align to pageblock, it will not init the migratetype.

What important impact does that have? It should leave a partial pageblock
as MIGRATE_UNMOVABLE which is fine by me.

> So call it for every page, it will takes more time, but it doesn't matter,
> this function will be called only in boot or hotadd memory.
>

It's a lot of additional overhead to add to memory initialisation. It
would need to be for an excellent reason with no alternative solution.

--
Mel Gorman
SUSE Labs


\
 
 \ /
  Last update: 2015-06-26 13:21    [W:0.038 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site