lkml.org 
[lkml]   [2015]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/22] perf stat: Introduce perf_evsel__alloc_stats function
    Date
    Move all stat allocation logic related to stat
    object under single function. This way we can
    use it separately for stat object out of evlist
    object.

    Link: http://lkml.kernel.org/n/tip-hclg66nszn5mx8t9uwrxxw6b@git.kernel.org
    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    ---
    tools/perf/util/stat.c | 20 ++++++++++++++------
    tools/perf/util/stat.h | 2 ++
    2 files changed, 16 insertions(+), 6 deletions(-)

    diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
    index 818cb022fcb6..f2a0d1521e26 100644
    --- a/tools/perf/util/stat.c
    +++ b/tools/perf/util/stat.c
    @@ -189,17 +189,25 @@ void perf_evsel__free_prev_raw_counts(struct perf_evsel *evsel)
    evsel->prev_raw_counts = NULL;
    }

    +int perf_evsel__alloc_stats(struct perf_evsel *evsel, bool alloc_raw)
    +{
    + int ncpus = perf_evsel__nr_cpus(evsel);
    + int nthreads = thread_map__nr(evsel->threads);
    +
    + if (perf_evsel__alloc_stat_priv(evsel) < 0 ||
    + perf_evsel__alloc_counts(evsel, ncpus, nthreads) < 0 ||
    + (alloc_raw && perf_evsel__alloc_prev_raw_counts(evsel, ncpus, nthreads) < 0))
    + return -ENOMEM;
    +
    + return 0;
    +}
    +
    int perf_evlist__alloc_stats(struct perf_evlist *evlist, bool alloc_raw)
    {
    struct perf_evsel *evsel;
    - int nthreads = thread_map__nr(evlist->threads);

    evlist__for_each(evlist, evsel) {
    - int ncpus = perf_evsel__nr_cpus(evsel);
    -
    - if (perf_evsel__alloc_stat_priv(evsel) < 0 ||
    - perf_evsel__alloc_counts(evsel, ncpus, nthreads) < 0 ||
    - (alloc_raw && perf_evsel__alloc_prev_raw_counts(evsel, ncpus, nthreads) < 0))
    + if (perf_evsel__alloc_stats(evsel, alloc_raw))
    goto out_free;
    }

    diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
    index 5f62db2472c7..9f05c571befe 100644
    --- a/tools/perf/util/stat.h
    +++ b/tools/perf/util/stat.h
    @@ -103,6 +103,8 @@ int perf_evsel__alloc_prev_raw_counts(struct perf_evsel *evsel,
    int ncpus, int nthreads);
    void perf_evsel__free_prev_raw_counts(struct perf_evsel *evsel);

    +int perf_evsel__alloc_stats(struct perf_evsel *evsel, bool alloc_raw);
    +
    int perf_evlist__alloc_stats(struct perf_evlist *evlist, bool alloc_raw);
    void perf_evlist__free_stats(struct perf_evlist *evlist);
    void perf_evlist__reset_stats(struct perf_evlist *evlist);
    --
    1.9.3


    \
     
     \ /
      Last update: 2015-06-26 11:41    [W:2.457 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site