Messages in this thread | | | Date | Fri, 26 Jun 2015 03:09:27 +0200 | From | "Luis R. Rodriguez" <> | Subject | Re: [PATCH v5 1/3] video: fbdev: atyfb: clarify ioremap() base and length used |
| |
On Fri, Jun 26, 2015 at 02:11:03AM +0300, Ville Syrjälä wrote: > On Thu, Jun 25, 2015 at 04:06:45PM -0700, Luis R. Rodriguez wrote: > > On Thu, Jun 25, 2015 at 4:04 PM, Ville Syrjälä <syrjala@sci.fi> wrote: > > > it doesn't hurt too much > > > since smem_len gets overwritten later in aty_init(). > > > > That's the idea, we set it with a default as it will be overwritten > > later anyway. > > Maybe toss in a comment? Otherwise it's a bit dishonest and might give > someone the impression that all PCI cards really have 8MB of memory.
Sure, mind this as a follow up patch if its too late?
Luis
| |