Messages in this thread | | | Date | Thu, 25 Jun 2015 15:29:08 +0100 | From | Mark Brown <> | Subject | Re: [RFC PATCH 1/2] regmap: add configurable lock class key for lockdep |
| |
On Thu, Jun 25, 2015 at 06:21:43AM -0700, Arjan van de Ven wrote:
Please fix your mailer to word wrap within paragraphs.
> wouldn't it be better to use the mutex_lock_nested() and co to > explicitly express your hierarchy?
That was one of my original suggestions - one of the problems with this code is that it's very much been presented as "here's the solution", it took a long time to even discover the problem they were trying to solve. I don't know exactly what the issue is supposed to be here, AFAICT the answers were about lock classes not about subclasses because apparently it's essential that we use lock classes. [unhandled content-type:application/pgp-signature] | |