lkml.org 
[lkml]   [2015]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/2] ARM-OMAP2+: Delete an unnecessary check before the function call "omap_device_delete"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 25 Jun 2015 13:00:11 +0200

    The omap_device_delete() function tests whether its argument is NULL and
    then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    arch/arm/mach-omap2/omap_device.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
    index 4cb8fd9..196366e 100644
    --- a/arch/arm/mach-omap2/omap_device.c
    +++ b/arch/arm/mach-omap2/omap_device.c
    @@ -193,8 +193,7 @@ static int _omap_device_notifier_call(struct notifier_block *nb,

    switch (event) {
    case BUS_NOTIFY_DEL_DEVICE:
    - if (pdev->archdata.od)
    - omap_device_delete(pdev->archdata.od);
    + omap_device_delete(pdev->archdata.od);
    break;
    case BUS_NOTIFY_ADD_DEVICE:
    if (pdev->dev.of_node)
    --
    2.4.4


    \
     
     \ /
      Last update: 2015-06-25 14:01    [W:4.023 / U:0.556 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site