lkml.org 
[lkml]   [2015]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver
On Thu, Jun 25, 2015 at 05:21:01PM +0800, Peter Hung wrote:
> Hi Johan,
>
> Johan Hovold 於 2015/6/25 下午 04:06 寫道:
> > - As Greg already mentioned, you need to implement gpio support using
> > gpiolib, not a custom sysfs interface
> >
> > I don't have time to look closer at the architectural bits until next
> > week I'm afraid, but perhaps you could start with the above.
>
> Thanks for your advices, I'll try to improve it again.
> But I had something need to clarify.
>
> 1. The sysfs interface of the driver provide "limited output pin"
> control. only support output 0/1, not support input mode.
> Should I implement it as gpiolib?

Yes.

> 2. If it still recommends to implement with gpiolib, Could I implement
> it and preserve the sysfs interface for legacy?

No, I'm afraid not. We don't want to have to maintain out-of-tree legacy
interfaces.

Johan


\
 
 \ /
  Last update: 2015-06-25 11:41    [W:0.420 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site