Messages in this thread Patch in this message | | | From | Geert Uytterhoeven <> | Subject | [PATCH 1/2] advansys: Do not byteswap sense_len on big endian | Date | Wed, 24 Jun 2015 10:29:48 +0200 |
| |
On big endian (e.g. m68k):
drivers/scsi/advansys.c: In function ‘adv_build_req’: drivers/scsi/advansys.c:7806: warning: large integer implicitly truncated to unsigned type
Indeed, adv_scsi_req_q.sense_len is uchar, not __le32, and must never be byteswapped.
Fixes: 811ddc057aac7228 ("advansys: use DMA-API for mapping sense buffer") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/scsi/advansys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 4305178e4e0147ba..1c1cd657c380c2e0 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -7803,7 +7803,7 @@ adv_build_req(struct asc_board *boardp, struct scsi_cmnd *scp, return ASC_BUSY; } scsiqp->sense_addr = cpu_to_le32(sense_addr); - scsiqp->sense_len = cpu_to_le32(SCSI_SENSE_BUFFERSIZE); + scsiqp->sense_len = SCSI_SENSE_BUFFERSIZE; /* Build ADV_SCSI_REQ_Q */ -- 1.9.1
| |