Messages in this thread | | | Date | Wed, 24 Jun 2015 11:31:02 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC][PATCH 12/13] stop_machine: Remove lglock |
| |
On Wed, Jun 24, 2015 at 10:32:57AM +0200, Peter Zijlstra wrote: > + s = atomic_long_read(&rsp->expedited_done); > + if (ULONG_CMP_GE((ulong)s, (ulong)snap)) { > + /* ensure test happens before caller kfree */ > + smp_mb__before_atomic(); /* ^^^ */
FWIW isn't that guaranteed by the control dep?
> + atomic_long_inc(&rsp->expedited_workdone1); > + goto unlock; > + }
| |