Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [PATCH 6/6] mtd: docg3: Don't do ERR_PTR(0) | Date | Tue, 23 Jun 2015 22:41:33 +0200 |
| |
Richard Weinberger <richard@nod.at> writes:
> Am 17.06.2015 um 20:41 schrieb Brian Norris: >> On Mon, Jun 01, 2015 at 11:10:54PM +0200, Richard Weinberger wrote: >>> Don't return a obfuscated null pointer using ERR_PTR(0). >>> If the no device is found clearly return -ENODEV. >>> This makes the code more clear and matches the comment >>> of doc_probe_device(). >>> >>> Signed-off-by: Richard Weinberger <richard@nod.at> >>> --- >> >> Have you tested this patch? > > nah, I don't own such a device. But I do. If you resend a patch, please Cc me. You can even ask for a test from time to time if you want a confirmation, I have a 2 floors docg3 device.
Cheers.
-- Robert
| |