Messages in this thread | | | Date | Tue, 23 Jun 2015 20:02:25 +0200 | From | Oleg Nesterov <> | Subject | [PATCH 0/1] mm: move ->mremap() from file_operations to vm_operations_struct |
| |
On 06/22, Andy Lutomirski wrote: > > On Mon, Jun 22, 2015 at 5:47 PM, Oleg Nesterov <oleg@redhat.com> wrote: > > > > I never understood why ->mremap() lives in file_operations, not in > > vm_operations_struct. To me vma->vm_file->f_op in move_vma() just > > looks strange, vma->vm_ops->mremap(new_vma) looks "obviously better". > > > > And afaics more useful. CRIU remaps vdso, but this does not update > > mm->context.vdso. OK, probably this does not matter currently, CRIU > > can't c/r the compat tasks, and 64-bit apps do not use context.vdso. > > Afaics. Still, I think we might want to have special_mapping_remap() > > and we can't do this because ->vm_file == NULL. > > I would like this. Then I could clean up and resubmit my patch to > keep context.vdso up to date.
Cough... where can I find this patch ? ;)
> Oleg, can you let me know what patch, if any, I should be reviewing?
This one, it looks really trivial. And of course I will appreciate it if you can review the special_mapping_fault() fixes.
The change in move_vma() textually depends on another patch I sent,
[PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails http://marc.info/?l=linux-kernel&m=143475603713622
Oleg.
| |