lkml.org 
[lkml]   [2015]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] iommu/arm-smmu: Fix bug in ARM_SMMU_FEAT_TRANS_OPS condition check
    From
    This issue has already been fixed here :
    http://www.spinics.net/lists/arm-kernel/msg424824.html

    Regards,
    Baptiste

    On Tue, Jun 23, 2015 at 2:07 PM, Sricharan R <sricharan@codeaurora.org> wrote:
    > Patch 'fix ARM_SMMU_FEAT_TRANS_OPS condition' changed the check
    > for ARM_SMMU_FEAT_TRANS_OPS to be based on presence of stage1 check,
    > but used (id & ID0_ATOSNS) instead of !(id & ID0_ATOSNS).
    > Fix it here.
    >
    > Signed-off-by: Sricharan R <sricharan@codeaurora.org>
    > ---
    > drivers/iommu/arm-smmu.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
    > index 09091e9..fbf4af6 100644
    > --- a/drivers/iommu/arm-smmu.c
    > +++ b/drivers/iommu/arm-smmu.c
    > @@ -1866,7 +1866,7 @@ static int arm_smmu_device_cfg_probe(struct arm_smmu_device *smmu)
    > return -ENODEV;
    > }
    >
    > - if ((id & ID0_S1TS) && ((smmu->version == 1) || (id & ID0_ATOSNS))) {
    > + if ((id & ID0_S1TS) && ((smmu->version == 1) || !(id & ID0_ATOSNS))) {
    > smmu->features |= ARM_SMMU_FEAT_TRANS_OPS;
    > dev_notice(smmu->dev, "\taddress translation ops\n");
    > }
    > --
    > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
    >


    \
     
     \ /
      Last update: 2015-06-23 14:21    [W:4.518 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site