lkml.org 
[lkml]   [2015]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 11/13] fs/locks: Replace lg_local with a per-cpu spinlock
Off-topic question,

On 06/22, Peter Zijlstra wrote:
>
> @@ -2650,9 +2660,8 @@ static void *locks_start(struct seq_file
>
> iter->li_pos = *pos + 1;
> percpu_down_write(&file_rwsem);
> - lg_global_lock(&file_lock_lglock);
> spin_lock(&blocked_lock_lock);
> - return seq_hlist_start_percpu(&file_lock_list, &iter->li_cpu, *pos);
> + return seq_hlist_start_percpu(&file_lock_list.hlist, &iter->li_cpu, *pos);
> }

...

> static void locks_stop(struct seq_file *f, void *v)
> __releases(&blocked_lock_lock)
> {
> spin_unlock(&blocked_lock_lock);

With or without this patch, why locks_start/locks_stop need to take/drop
blocked_lock_lock ?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2015-06-23 02:41    [W:0.346 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site