Messages in this thread | | | Date | Mon, 22 Jun 2015 13:52:55 -0400 | From | Tejun Heo <> | Subject | Re: WARNING: at fs/block_dev.c:5 when removing LV on removed device |
| |
Hello,
On Mon, Jun 22, 2015 at 01:46:48PM -0400, Vivek Goyal wrote: > Subject: fs/block_dev.c: Warn on inode writeback failure instead of WARN_ON() > > If a block device is hot removed and later last reference to devices > is put, we try to writeback the dirty inode. But device is gone and > that writeback fails. > > Currently we do a WARN_ON() which does not seem to be the right thing. > Convert it to a ratelimited kernel warning.
Yeah, looks good to me. Just one nit.
... > + if (write_inode_now(inode, true)) { > + char name[BDEVNAME_SIZE] = ""; > + pr_warn_ratelimited("VFS: Dirty inode writeback failed for block device %s.\n", bdevname(bdev, name));
This wasn't reported before either but maybe we wanna report the errno too? Also, don't we usually break the line for parameters?
pr_..("long format string going over 80 col...\n", param0, param1, ...);
Thanks.
-- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
| |