Messages in this thread | | | Date | Mon, 22 Jun 2015 19:06:59 +0300 | From | Andrey Ryabinin <> | Subject | Re: [PATCH 3/3] x86_64: kasan: add message about kasan being initialized |
| |
On 06/20/2015 04:18 PM, Ingo Molnar wrote: > > Please call it 'kasan' or 'KASAN', and also explain it in the message and prefix > it properly with the subsystem name (kasan), so something like: > > pr_info("kasan: Kernel Address SANitizer (KASAN) initialized\n"); > > Other kasan messages should also carry a 'kasan: ' prefix, so that it's > unambiguous what generated the message, and also to make it easier to grep out of > logs. >
This patch adds "kasan: " prefix for all messages from this file ( +#define pr_fmt(fmt) "kasan: " fmt )
I'm agree with Dmitry, I would choose kasan name too. In this case, adding explanation in the message will produce too much kasans in one short message:
kasan: Kernel address sanitizer (kasan) initialized
Perhaps it would be better to keep this patch as is. Ok? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
| |