lkml.org 
[lkml]   [2015]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] regmap: debugfs: Allow writes to cache state settings
On Mon, Jun 22, 2015 at 04:30:34PM +0100, Richard Fitzgerald wrote:

This looks basically good but:

> +static ssize_t regmap_bool_read_file(struct file *file,
> + char __user *user_buf,
> + size_t count, loff_t *ppos,
> + bool value)
> +{
> + char buf[2];
> +
> + buf[0] = value ? 'Y' : 'N';
> + buf[1] = '\n';
> + return simple_read_from_buffer(user_buf, count, ppos, buf, sizeof(buf));
> +}

> +static ssize_t regmap_bool_write_file(struct file *file,
> + const char __user *user_buf,
> + size_t count, loff_t *ppos,
> + bool *value)
> +{

Can we not export read/write_file_bool() instead? For the read this
seems to be an almost cut'n'paste with slight differences that look
like taste changes. For the write path we can just stash the current
value in the calling functions instead of cut'n'pasting the code.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-06-22 18:01    [W:3.330 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site