lkml.org 
[lkml]   [2015]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration().
From
On Mon, Jun 1, 2015 at 11:40 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> From: Shailendra Verma <shailendra.capricorn@gmail.com>
>
> The variable dirty is bool type. Hence assign the variable with
> bool value true/false instead of 1/0.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> Tested-by: Michal Simek <michal.simek@xilinx.com>
Feel free to add:
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>
> drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c
> index 05d897764f02..53c3882e4981 100644
> --- a/drivers/char/xilinx_hwicap/buffer_icap.c
> +++ b/drivers/char/xilinx_hwicap/buffer_icap.c
> @@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
> int status;
> s32 buffer_count = 0;
> s32 num_writes = 0;
> - bool dirty = 0;
> + bool dirty = false;
> u32 i;
> void __iomem *base_address = drvdata->base_address;
>
> @@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> /* Copy data to bram */
> buffer_icap_set_bram(base_address, buffer_count, data[i]);
> - dirty = 1;
> + dirty = true;
>
> if (buffer_count < XHI_MAX_BUFFER_INTS - 1) {
> buffer_count++;
> @@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data,
>
> buffer_count = 0;
> num_writes++;
> - dirty = 0;
> + dirty = false;
> }
>
> /* Write unwritten data to ICAP */
> --
> 2.3.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


\
 
 \ /
  Last update: 2015-06-02 19:21    [W:0.437 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site