Messages in this thread | | | Date | Tue, 2 Jun 2015 10:09:15 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] livepatch: add module locking around kallsyms calls |
| |
On Mon, Jun 01, 2015 at 05:48:37PM +0200, Miroslav Benes wrote: > The list of loaded modules is walked through in > module_kallsyms_on_each_symbol (called by kallsyms_on_each_symbol). The > module_mutex lock should be acquired to prevent potential corruptions > in the list. > > This was uncovered with new lockdep asserts in module code introduced by > the commit 0be964be0d45 ("module: Sanitize RCU usage and locking") in > recent next- trees. > > Signed-off-by: Miroslav Benes <mbenes@suse.cz>
Thanks!
Should we add a comment to kallsyms_on_each_symbol() so that others don't make this mistake?
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
-- Josh
| |