Messages in this thread | | | Date | Tue, 02 Jun 2015 06:44:48 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] watchdog: mena21_wdt: Fix possible NULL pointer dereference |
| |
On 06/02/2015 03:25 AM, Johannes Thumshirn wrote: > In a21_wdt_remove() we do a watchdog_unregister_device() on struct > a21_wdt_drv->wdt but never assign it. > > Also move the dev_set_drvdata() call in front of the watchdog_register_device() > call, so it doesn't look like an error. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Good catch.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Guenter
| |