lkml.org 
[lkml]   [2015]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] USB: ftdi_sio: add GPIO support
From
On Sat, May 30, 2015 at 10:29 PM, Grant Likely
<grant.likely@secretlab.ca> wrote:
> On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:

>>> However is the MFD cell approach acceptable?
>>
>> Yes it is.
>
> Going back to this old conversation... Actually, I disagree. There is
> absolutely no need to go the MFD approach for this driver. That just
> adds layers of abstraction for no purpose. GPIOLIB is an interface,
> and it is completely fine for a driver to hook up to the GPIOLIB
> interface at the same time as exposing a serial port. MFD doesn't buy
> the driver anything useful here.

What is buys is centralizing code into the proper drivers/gpio
folder of the kernel. So more of a maintenance point than a
mechanics/performance point.

We do have GPIO drivers scattered all over the kernel so one
more or less wouldn't matter so much...

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2015-06-02 15:41    [W:0.078 / U:6.632 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site