Messages in this thread | | | Date | Tue, 02 Jun 2015 22:12:44 +0900 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH] power_supply: bq25890: make chip_id int |
| |
W dniu 02.06.2015 o 19:36, Laurentiu Palcu pisze: > Smatch static checker correctly detected an impossible condition because > chip_id was declared as u8, instead of int: > > drivers/power/bq25890_charger.c:843 bq25890_probe() > warn: impossible condition '(bq->chip_id < 0) => (0-255 < 0)' > > Also, while at it, fix the return value too.
I wondered whether this should be split into two commits... but actually returning uninitialized value is not possible now because of the cast, so:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards, Krzysztof
| |