Messages in this thread | | | Date | Tue, 2 Jun 2015 11:26:43 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH] checkpatch: Make the output better readable |
| |
On Mon 2015-06-01 11:02:42, Joe Perches wrote: > On Mon, 2015-06-01 at 16:25 +0200, Petr Mladek wrote: > > I always have troubles to parse checkpatch.pl output when I check > > the whole patchset. It is hard to say which messages belongs to > > what patch. > > > > This patch does few small changes to make the output look better > > for me: > > As git and other utilities now use color by default, what do > you think about adding color for various message types? > > And colorize only to the terminal, not any redirected output.
JFYI, the output with this patch looks fine to me but to be honest I do not mind much about it.
I sent a patch that helped me a lot with parsing. If it is accepted in some form, it would be great. I am sure that more improvements are possible.
But all this is matter of personal taste. I am afraid that this theme is prone for bikeshedding and I do not want to get involved if possible :-)
Best Regards, Petr
> Maybe something like: > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index c8032a0..12c43c6 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -9,6 +9,7 @@ use strict; > use POSIX; > use File::Basename; > use Cwd 'abs_path'; > +use Term::ANSIColor qw(:constants); > > my $P = $0; > my $D = dirname(abs_path($P)); > @@ -1649,10 +1650,24 @@ sub report { > return 0; > } > my $line; > + my $cprefix = $prefix; > + my $clevel = $level; > + my $ctype = $type; > + if (-t STDOUT) { > + $cprefix = GREEN . $prefix . RESET; > + if ($level eq "ERROR") { > + $clevel = RED . $level . RESET; > + } elsif ($level eq "WARNING") { > + $clevel = YELLOW . $level . RESET; > + } else { > + $clevel = GREEN . $level . RESET; > + } > + $ctype = GREEN . $type . RESET; > + } > if ($show_types) { > - $line = "$prefix$level:$type: $msg\n"; > + $line = "$cprefix$clevel:$ctype: $msg\n"; > } else { > - $line = "$prefix$level: $msg\n"; > + $line = "$cprefix$clevel: $msg\n"; > } > $line = (split('\n', $line))[0] . "\n" if ($terse); > > >
| |